jiayuasu commented on PR #1095: URL: https://github.com/apache/sedona-db/pull/1095#issuecomment-5222471771
Thanks for catching this, and sorry for the breakage. Fix is up in #1134. Cause: the `geopandas / geopandas-build` job ran for the first time after this merged — before that it was always skipped, because the extension jobs were gated behind platform jobs that were failing — and its test step needs `geoarrow-pyarrow`, which was not being installed. GeoPandas interop in this package goes through sedonadb's pandas conversion, which imports `geoarrow.pyarrow`, so every test that materializes a frame failed with `No module named 'geoarrow'`. It was missing in two places: the package's `geopandas`/`test` extras (so `pip install sedonadb-geopandas[geopandas]` was broken for users too, not just CI), and the wheels job, which listed test dependencies inline and installed the bare wheel, so it never read the extras. #1134 fixes both, and has the wheels job install the wheel with its `[test]` extra so the list has a single home. It stayed hidden because both the dev environment and the `python.yml` job install `sedonadb[test]`, which happens to provide `geoarrow-pyarrow` — only a clean environment exposes it. #1134 also adds a small nightly-based workflow that runs the package's tests in exactly such an environment in about a minute, so this class of problem surfaces before merge rather than after. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
