[
https://issues.apache.org/jira/browse/SENTRY-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349521#comment-16349521
]
Vadim Spector commented on SENTRY-2109:
---------------------------------------
I think it's useful to have as many reviews as possible, so if [~akolb] wants
to review it may be worth to reopen it.
[~spena], it is correct, for now this logic is going to be on hold, so there is
no rush in committing it. Since it's almost complete (unless the remaining
reviewers find something wrong), it can be a legitimate plan B, if HMS fix is
found to have any serious issues.
> Fix the logic of identifying HMS out of Sync and handle gaps and
> out-of-sequence notifications.
> -----------------------------------------------------------------------------------------------
>
> Key: SENTRY-2109
> URL: https://issues.apache.org/jira/browse/SENTRY-2109
> Project: Sentry
> Issue Type: Bug
> Components: Sentry
> Affects Versions: 2.1.0
> Reporter: kalyan kumar kalvagadda
> Assignee: kalyan kumar kalvagadda
> Priority: Major
> Fix For: 2.1.0
>
> Attachments: SENTRY-2109.001.patch, SENTRY-2109.002.patch,
> SENTRY-2109.003.patch, SENTRY-2109.004.patch, SENTRY-2109.005.patch,
> SENTRY-2109.006.patch, SENTRY-2109.007.patch, SENTRY-2109.008.patch,
> SENTRY-2109.009.patch, SENTRY-2109.010.patch, SENTRY-2109.010.patch,
> SENTRY-2109.011.patch, SENTRY-2109.012.patch, SENTRY-2109.012.patch,
> SENTRY-2109.012.patch, Screenshot_HMS_NOTIFICATION_LOG.png
>
>
> Currently HMSFollower proactively checks if sentry is out of sync with HMS
> and initiates full snapshot, if needed.
> There will be false positives with the current logic if there are gaps in the
> event-id in the notification log sequence.
> This jira is aimed at making that logic robust.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
