desruisseaux commented on code in PR #40:
URL: https://github.com/apache/sis/pull/40#discussion_r2792551411
##########
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/FileService.java:
##########
@@ -216,17 +283,44 @@ public FileSystem newFileSystem(final URI uri, final
Map<String,?> properties) t
} else {
region = Containers.property(properties, AWS_REGION, Region.class);
}
- final class Creator implements Function<String, ClientFileSystem> {
+ final class Creator implements Function<ClientFileSystemKey,
ClientFileSystem> {
/** Identifies if a new file system is created. */ boolean created;
/** Invoked if the map does not already contains the file system.
*/
- @Override public ClientFileSystem apply(final String key) {
+ @Override public ClientFileSystem apply(final ClientFileSystemKey
key) {
created = true;
- return new ClientFileSystem(FileService.this, region, key,
secret, separator);
+ return new ClientFileSystem(FileService.this, region,
key.getHost(), key.getPort(), key.isHttps(), key.getAccessKey(), secret,
separator);
Review Comment:
If this is the only place where this constructor is invoked, or if all
invocations of this constructor follow the same pattern, we can pass directly
the `ClientFileSystemKey` to the constructor instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
