sonatype-lift[bot] commented on code in PR #1128:
URL: https://github.com/apache/solr/pull/1128#discussion_r1005843806
##########
solr/core/src/java/org/apache/solr/filestore/DistribPackageStore.java:
##########
@@ -72,16 +72,16 @@ public class DistribPackageStore implements PackageStore {
private final CoreContainer coreContainer;
private Map<String, FileInfo> tmpFiles = new ConcurrentHashMap<>();
- private final Path solrhome;
+ private final Path solrHome;
public DistribPackageStore(CoreContainer coreContainer) {
this.coreContainer = coreContainer;
- this.solrhome = Paths.get(this.coreContainer.getSolrHome());
+ this.solrHome = Paths.get(this.coreContainer.getSolrHome());
Review Comment:
I've recorded this as ignored for this pull request.
If you change your mind, just comment `@sonatype-lift unignore`.
##########
solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java:
##########
@@ -1628,9 +1629,9 @@ public DirectoryFileStream(SolrParams solrParams) {
}
// Throw exception on directory traversal attempts
- protected String validateFilenameOrError(String filename) {
- if (filename != null) {
- Path filePath = Paths.get(filename);
+ protected String validateFilenameOrError(String fileName) {
+ if (fileName != null) {
+ Path filePath = Paths.get(fileName);
Review Comment:
I've recorded this as ignored for this pull request.
If you change your mind, just comment `@sonatype-lift unignore`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
