dsmiley commented on code in PR #1128:
URL: https://github.com/apache/solr/pull/1128#discussion_r1007546724
##########
solr/core/src/test/org/apache/solr/response/TestRetrieveFieldsOptimizer.java:
##########
@@ -411,21 +411,20 @@ static enum TEST_TYPE {
}
static final Map<TEST_TYPE, String> solrClassMap =
- Collections.unmodifiableMap(
- Stream.of(
- new SimpleEntry<>(TEST_TYPE.TINT, "solr.TrieIntField"),
- new SimpleEntry<>(TEST_TYPE.TLONG, "solr.TrieLongField"),
- new SimpleEntry<>(TEST_TYPE.TFLOAT, "solr.TrieFloatField"),
- new SimpleEntry<>(TEST_TYPE.TDOUBLE, "solr.TrieDoubleField"),
- new SimpleEntry<>(TEST_TYPE.TDATE, "solr.TrieDateField"),
- new SimpleEntry<>(TEST_TYPE.PINT, "solr.IntPointField"),
- new SimpleEntry<>(TEST_TYPE.PLONG, "solr.LongPointField"),
- new SimpleEntry<>(TEST_TYPE.PFLOAT, "solr.FloatPointField"),
- new SimpleEntry<>(TEST_TYPE.PDOUBLE,
"solr.DoublePointField"),
- new SimpleEntry<>(TEST_TYPE.PDATE, "solr.DatePointField"),
- new SimpleEntry<>(TEST_TYPE.STRING, "solr.StrField"),
- new SimpleEntry<>(TEST_TYPE.BOOL, "solr.BoolField"))
- .collect(Collectors.toMap(Map.Entry::getKey,
Map.Entry::getValue)));
+ Stream.of(
Review Comment:
No point in using Stream without any transformation. Here, just call
`Map.ofEntries`
##########
solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java:
##########
@@ -87,7 +87,7 @@ public boolean isTripped() {
@Override
public String getDebugInfo() {
- if (seenCPUUsage.get() == 0.0 || seenCPUUsage.get() == 0.0) {
+ if (seenCPUUsage.get() == 0.0 || allowedCPUUsage.get() == 0.0) {
Review Comment:
cool; perhaps an actual bug
##########
solr/core/src/java/org/apache/solr/search/stats/LRUStatsCache.java:
##########
@@ -129,7 +129,7 @@ protected ShardRequest
doRetrieveStatsRequest(ResponseBuilder rb) {
// force-fetched on next request and cached.
// check for missing stats from previous requests
- if (!missingColStats.isEmpty() || !missingColStats.isEmpty()) {
+ if (!missingColStats.isEmpty() || !missingTermStats.isEmpty()) {
Review Comment:
cool; perhaps an actual bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
