risdenk commented on code in PR #1128:
URL: https://github.com/apache/solr/pull/1128#discussion_r1005894771


##########
solr/core/src/java/org/apache/solr/schema/OpenExchangeRatesOrgProvider.java:
##########
@@ -151,7 +151,7 @@ public boolean reload() throws SolrException {
     try {
       log.debug("Reloading exchange rates from {}", ratesFileLocation);
       try {
-        ratesJsonStream = (new URL(ratesFileLocation)).openStream();
+        ratesJsonStream = new URL(ratesFileLocation).openStream();

Review Comment:
   @sonatype-lift ignoreall



##########
solr/core/src/java/org/apache/solr/util/SolrCLI.java:
##########
@@ -3228,7 +3281,7 @@ protected Map<String, Object> startSolr(
       String addlOptsArg = (addlOpts != null) ? " -a \"" + addlOpts + "\"" : 
"";
 
       File cwd = new File(System.getProperty("user.dir"));
-      File binDir = (new File(script)).getParentFile();
+      File binDir = new File(script).getParentFile();

Review Comment:
   @sonatype-lift ignoreall



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to