risdenk commented on code in PR #1128:
URL: https://github.com/apache/solr/pull/1128#discussion_r1005941617
##########
gradle/validation/error-prone.gradle:
##########
@@ -62,48 +62,36 @@ allprojects { prj ->
options.errorprone.disableWarningsInGeneratedCode = true
options.errorprone.errorproneArgs = [
- '-Xep:InlineMeSuggester:OFF', // We don't use this annotation
Review Comment:
Moved down to alphabetical order below
##########
solr/core/src/java/org/apache/solr/parser/QueryParserTokenManager.java:
##########
@@ -16,7 +17,9 @@
+
/** Token Manager. */
+@Generated("JavaCC")
Review Comment:
TODO @risdenk find a way to do this as part of `./gradlew javacc`
##########
solr/core/src/test/org/apache/solr/cloud/TestTlogReplica.java:
##########
@@ -679,7 +679,7 @@ public void testRecovery() throws Exception {
waitingForReplay.release();
waitingForBufferUpdates.acquire();
} catch (InterruptedException e) {
- e.printStackTrace();
Review Comment:
TODO @risdenk add log.error...
##########
solr/core/src/test/org/apache/solr/cloud/TrollingIndexReaderFactory.java:
##########
@@ -204,7 +203,7 @@ private static void recordStackTrace(StackTraceElement[]
stackTrace) {
try {
lastStacktraces.poll(100, TimeUnit.MILLISECONDS);
} catch (InterruptedException e1) {
- e1.printStackTrace();
+ Thread.currentThread().interrupt();
Review Comment:
TODO @risdenk add log.error...
##########
solr/core/src/test/org/apache/solr/cloud/ZkShardTermsTest.java:
##########
@@ -223,7 +223,7 @@ public void testRaceConditionOnUpdates() throws
InterruptedException {
Thread.sleep(random().nextInt(200));
zkShardTerms.setTermEqualsToLeader(replica);
} catch (InterruptedException e) {
- e.printStackTrace();
+ Thread.currentThread().interrupt();
Review Comment:
TODO @risdenk add log.error...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
