risdenk commented on PR #1128: URL: https://github.com/apache/solr/pull/1128#issuecomment-1295019929
> SOLR-16427: Evaluate and fix errorprone rules - BadShiftAmount, as I didn't udnerstand how you got those magic numbers well I didn't do the calculations :) errorprone did. The idea is that there is wraparound so the shifts can only be within a certain range. See https://errorprone.info/bugpattern/BadShiftAmount for an explanation. > I also don't love that the way we look up our log is via private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); so historically logging in Solr was even more of a mess since the logger would point to the wrong class with copy/paste. This pattern at least ensures that the logger in one class will apply to that class - even if you copy paste to new code. So yea its a bit wonky but I'm a fan. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
