epugh commented on code in PR #1206:
URL: https://github.com/apache/solr/pull/1206#discussion_r1038638407
##########
solr/core/src/test/org/apache/solr/cloud/TestCloudRecovery.java:
##########
@@ -49,7 +49,6 @@
public class TestCloudRecovery extends SolrCloudTestCase {
- private static final String COLLECTION = "collection1";
Review Comment:
i started acoutally out with that... And my thought was that the value of
this entire PR is directly based on how much we get every test in every file to
using the same name... I really didn't want to go through by hand and fix
all of these... ;-). My thought is that by using the label
DEFAULT_TEST_COLLECTION_NAME everywhere, it signals to you that you don't need
to think about what the `COLLECTION` or `collection` variable means.. and
that if you see either of those variables, then it presumably matters for some
reason to that test....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
