[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1206: SOLR-16564: Migrate to using DEFAULT_TEST_COLLECTION_NAME constant through out tests

Fri, 02 Dec 2022 17:00:49 -0800 


sonatype-lift[bot] commented on code in PR #1206:
URL: https://github.com/apache/solr/pull/1206#discussion_r1038653818


##########
solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java:
##########
@@ -917,12 +917,12 @@ protected void updateMappingsFromZk(
       List<JettySolrRunner> jettys, List<SolrClient> clients, boolean 
allowOverSharding)
       throws Exception {
     ZkStateReader zkStateReader = ZkStateReader.from(cloudClient);
-    zkStateReader.forceUpdateCollection(DEFAULT_COLLECTION);
+    zkStateReader.forceUpdateCollection(DEFAULT_TEST_COLLECTION_NAME);
     cloudJettys.clear();
     shardToJetty.clear();
 
     ClusterState clusterState = zkStateReader.getClusterState();
-    DocCollection coll = clusterState.getCollection(DEFAULT_COLLECTION);
+    DocCollection coll = 
clusterState.getCollection(DEFAULT_TEST_COLLECTION_NAME);

Review Comment:
   ![25% of developers fix this 
issue](https://lift.sonatype.com/api/commentimage/fixrate/25/display.svg)
   
   *NULL_DEREFERENCE:*  object `clusterState` last assigned on line 924 could 
be null and is dereferenced at line 925.
   
   ---
   
   <details><summary><b>ℹī¸ Learn about @sonatype-lift commands</b></summary>
   
   You can reply with the following commands. For example, reply with 
***@sonatype-lift ignoreall*** to leave out all findings.
   | **Command** | **Usage** |
   | ------------- | ------------- |
   | `@sonatype-lift ignore` | Leave out the above finding from this PR |
   | `@sonatype-lift ignoreall` | Leave out all the existing findings from this 
PR |
   | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified 
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
   
   **Note:** When talking to LiftBot, you need to **refresh** the page to see 
its response.
   <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) 
to add LiftBot to another repo.</sub></details>
   
   
   
   ---
   
   Was this a good recommendation?
   [ [🙁 Not 
relevant](https://www.sonatype.com/lift-comment-rating?comment=357580325&lift_comment_rating=1)
 ] - [ [😕 Won't 
fix](https://www.sonatype.com/lift-comment-rating?comment=357580325&lift_comment_rating=2)
 ] - [ [😑 Not critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=357580325&lift_comment_rating=3)
 ] - [ [🙂 Critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=357580325&lift_comment_rating=4)
 ] - [ [😊 Critical, fixing 
now](https://www.sonatype.com/lift-comment-rating?comment=357580325&lift_comment_rating=5)
 ]



##########
solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java:
##########
@@ -2162,13 +2162,13 @@ ZkStateReader.PULL_REPLICAS, getPullReplicaCount(),
 
   @Override
   protected SolrClient createNewSolrClient(int port) {
-    return createNewSolrClient(DEFAULT_COLLECTION, port);
+    return createNewSolrClient(DEFAULT_TEST_COLLECTION_NAME, port);

Review Comment:
   ![25% of developers fix this 
issue](https://lift.sonatype.com/api/commentimage/fixrate/25/display.svg)
   
   *THREAD_SAFETY_VIOLATION:*  Unprotected write. Non-private method 
`AbstractFullDistribZkTestBase.createNewSolrClient(...)` indirectly mutates 
container `util.ObjectReleaseTracker.OBJECTS` via call to `Map.put(...)` 
outside of synchronization.
    Reporting because another access to the same memory occurs on a background 
thread, although this access may not.
   
   ---
   
   <details><summary><b>ℹī¸ Learn about @sonatype-lift commands</b></summary>
   
   You can reply with the following commands. For example, reply with 
***@sonatype-lift ignoreall*** to leave out all findings.
   | **Command** | **Usage** |
   | ------------- | ------------- |
   | `@sonatype-lift ignore` | Leave out the above finding from this PR |
   | `@sonatype-lift ignoreall` | Leave out all the existing findings from this 
PR |
   | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified 
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
   
   **Note:** When talking to LiftBot, you need to **refresh** the page to see 
its response.
   <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) 
to add LiftBot to another repo.</sub></details>
   
   
   
   ---
   
   Was this a good recommendation?
   [ [🙁 Not 
relevant](https://www.sonatype.com/lift-comment-rating?comment=357579956&lift_comment_rating=1)
 ] - [ [😕 Won't 
fix](https://www.sonatype.com/lift-comment-rating?comment=357579956&lift_comment_rating=2)
 ] - [ [😑 Not critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=357579956&lift_comment_rating=3)
 ] - [ [🙂 Critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=357579956&lift_comment_rating=4)
 ] - [ [😊 Critical, fixing 
now](https://www.sonatype.com/lift-comment-rating?comment=357579956&lift_comment_rating=5)
 ]



##########
solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java:
##########
@@ -316,14 +316,14 @@ protected String getDataDir(String dataDir) throws 
IOException {
   protected void initCloud() throws Exception {
     assert (cloudInit == false);
     cloudInit = true;
-    cloudClient = createCloudClient(DEFAULT_COLLECTION);
+    cloudClient = createCloudClient(DEFAULT_TEST_COLLECTION_NAME);

Review Comment:
   ![25% of developers fix this 
issue](https://lift.sonatype.com/api/commentimage/fixrate/25/display.svg)
   
   *THREAD_SAFETY_VIOLATION:*  Unprotected write. Non-private method 
`AbstractFullDistribZkTestBase.initCloud()` indirectly mutates container 
`util.ObjectReleaseTracker.OBJECTS` via call to `Map.put(...)` outside of 
synchronization.
    Reporting because another access to the same memory occurs on a background 
thread, although this access may not.
   
   ---
   
   <details><summary><b>ℹī¸ Learn about @sonatype-lift commands</b></summary>
   
   You can reply with the following commands. For example, reply with 
***@sonatype-lift ignoreall*** to leave out all findings.
   | **Command** | **Usage** |
   | ------------- | ------------- |
   | `@sonatype-lift ignore` | Leave out the above finding from this PR |
   | `@sonatype-lift ignoreall` | Leave out all the existing findings from this 
PR |
   | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified 
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
   
   **Note:** When talking to LiftBot, you need to **refresh** the page to see 
its response.
   <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) 
to add LiftBot to another repo.</sub></details>
   
   
   
   ---
   
   Was this a good recommendation?
   [ [🙁 Not 
relevant](https://www.sonatype.com/lift-comment-rating?comment=357580298&lift_comment_rating=1)
 ] - [ [😕 Won't 
fix](https://www.sonatype.com/lift-comment-rating?comment=357580298&lift_comment_rating=2)
 ] - [ [😑 Not critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=357580298&lift_comment_rating=3)
 ] - [ [🙂 Critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=357580298&lift_comment_rating=4)
 ] - [ [😊 Critical, fixing 
now](https://www.sonatype.com/lift-comment-rating?comment=357580298&lift_comment_rating=5)
 ]



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to