stillalex commented on code in PR #1211:
URL: https://github.com/apache/solr/pull/1211#discussion_r1039797943
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java:
##########
@@ -88,23 +89,63 @@ public LBHttp2SolrClient(Http2SolrClient httpClient,
String... baseSolrUrls) {
this.httpClient = httpClient;
}
+ public LBHttp2SolrClient(Http2SolrClient httpClient, List<String>
baseSolrUrls, Builder builder) {
Review Comment:
should this be 'protected' instead of 'public'?
also you could consider marking the existing constructor as Deprecated, if
you want to move to Builder only patterns, no one should call it directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
