epugh commented on code in PR #1211:
URL: https://github.com/apache/solr/pull/1211#discussion_r1039717680
##########
solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java:
##########
@@ -2886,28 +2906,25 @@ public static HttpSolrClient getHttpSolrClient(
}
/**
- * This method <i>may</i> randomize unspecified aspects of the resulting
SolrClient. Tests that do
- * not wish to have any randomized behavior should use the {@link
- * org.apache.solr.client.solrj.impl.HttpSolrClient.Builder} class directly
+ * This method creates a basic HttpSolrClient. Tests that want to control
the creation process
+ * should use the {@link
org.apache.solr.client.solrj.impl.HttpSolrClient.Builder} class directly
*/
public static HttpSolrClient getHttpSolrClient(
String url, HttpClient httpClient, ResponseParser responseParser) {
return new
Builder(url).withHttpClient(httpClient).withResponseParser(responseParser).build();
}
/**
- * This method <i>may</i> randomize unspecified aspects of the resulting
SolrClient. Tests that do
- * not wish to have any randomized behavior should use the {@link
- * org.apache.solr.client.solrj.impl.HttpSolrClient.Builder} class directly
+ * This method creates a basic HttpSolrClient. Tests that want to control
the creation process
+ * should use the {@link
org.apache.solr.client.solrj.impl.HttpSolrClient.Builder} class directly
*/
public static HttpSolrClient getHttpSolrClient(String url, HttpClient
httpClient) {
return new Builder(url).withHttpClient(httpClient).build();
}
/**
- * This method <i>may</i> randomize unspecified aspects of the resulting
SolrClient. Tests that do
- * not wish to have any randomized behavior should use the {@link
- * org.apache.solr.client.solrj.impl.HttpSolrClient.Builder} class directly
+ * This method creates a basic HttpSolrClient. Tests that want to control
the creation process
+ * should use the {@link
org.apache.solr.client.solrj.impl.HttpSolrClient.Builder} class directly
Review Comment:
I don't think we did.... This change was to make sure the docs reflect the
actual code.. Unless I misread the code, it actually doesn't do any
randomization!
I do think that there is room to rethink adding randomization into tests,
right now it's a werid mix of some un random and some random...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
