epugh commented on PR #1211: URL: https://github.com/apache/solr/pull/1211#issuecomment-1337579391
@dsmiley I think I've responded to all your comments, thanks for doing that. The only i think big outstanding issue is the question about the two LB clients... Does it ever make sense to configure the requestwriter and responseparser on the LB? when you literally pass in a HttpSolrClient or Http2SolrClient? The only place we use withRequestWriter or withResponseParser is in the unit tests. Do you think I should rip that stuff out? In future PR's I'd like to tackle: * Fix the getServerUrl stuff, and the confusion over a root url and a /collection1 url. * Change getHttpClient to be the Jetty HttpClient * Go through the various createHttpClient helpers and see if we need all of them, or if only used by one class, move it there. Or even remove them in favour of the try/with resources and builders in our methods... * Get rid of the deprecated methods on the various Clients. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
