epugh commented on code in PR #1951:
URL: https://github.com/apache/solr/pull/1951#discussion_r1335004353
##########
solr/core/src/java/org/apache/solr/cli/CreateTool.java:
##########
@@ -131,7 +134,7 @@ public void runImpl(CommandLine cli) throws Exception {
protected void createCore(CommandLine cli, SolrClient solrClient) throws
Exception {
String coreName = cli.getOptionValue("name");
- String solrUrl = cli.getOptionValue("solrUrl",
SolrCLI.getDefaultSolrUrl());
+ String solrUrl = cli.getOptionValue("solrUrl",
SolrCLI.getDefaultSolrUrl(cli));
Review Comment:
Out of curiosity, if `SolrCLI.getDefaultSolrUrl(cli))` always takes a cli,
should we make it be `cli.getDefaultSolrUrl()` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
