epugh commented on code in PR #1951:
URL: https://github.com/apache/solr/pull/1951#discussion_r1335004689
##########
solr/core/src/java/org/apache/solr/cli/PackageTool.java:
##########
@@ -310,6 +310,18 @@ private Pair<String, String> parsePackageVersion(String
arg) {
public List<Option> getOptions() {
return List.of(
SolrCLI.OPTION_SOLRURL,
+ // Cannot use the default OPTION_SOLRPORT, because -p is already taken
by PARAMS
Review Comment:
Yeah... I wonder if we should make the slightly breaking chagne? This
feels like we are going to get bit by this in the future? Or, do we think
humans will never actually use teh `-p` parameter to mean a solr port, becuase
it's a config file type thing... I could see just forcing --package, cause
how often do you type this command? whereas -p is super common IF we think
humans will use these parameters a lot. <-- did that make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
