epugh commented on code in PR #1951:
URL: https://github.com/apache/solr/pull/1951#discussion_r1335007469


##########
solr/packaging/test/test_packages.bats:
##########
@@ -29,7 +29,12 @@ teardown() {
 }
 
 @test "package detects no running solr" {
-  # not sure this is actually a good thing..  we may not want this..

Review Comment:
   I kind of want to keep this comment...   There is an issue open to look at 
this.   Why do we check if solr is running on this command?   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to