dsmiley commented on code in PR #2126:
URL: https://github.com/apache/solr/pull/2126#discussion_r1441805546
##########
solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java:
##########
@@ -165,6 +166,9 @@ public static NodeConfig fromConfig(
if (cloudConfig != null) configBuilder.setCloudConfig(cloudConfig);
configBuilder.setBackupRepositoryPlugins(
getBackupRepositoryPluginInfos(root.get("backup").getAll("repository")));
+
configBuilder.setClusterPluginsSource(getPluginInfo(root.get("clusterPluginsSource")));
Review Comment:
note `org.apache.solr.handler.SolrConfigHandler#configEditing_disabled` is a
public static final, but for testability you can change that. If we expand the
use as I suggest, it even deserves a more global location, like on NodeConfig
perhaps (even if not actually configured in solr.xml).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
