pvcnt commented on PR #2126: URL: https://github.com/apache/solr/pull/2126#issuecomment-1877435871
The point I am raising about validation has actually already been raised by Paul there: https://github.com/apache/solr/pull/2126/files#r1424690508 I think it would be a mistake to not enforce the a `<clusterSingleton/>` actually defines a cluster singleton and not a replica placement plugin. Otherwise, what is the point of having a type tag, besides providing some documentation? Again, with the current implementation, you can perfectly declare a replica placement plugin (or any kind of cluster plugin really) inside a `<clusterSingleton/>` and it will just work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
