dsmiley commented on PR #2126: URL: https://github.com/apache/solr/pull/2126#issuecomment-1877290383
> I believe it would still be interesting to have at least two different plugin types to validate that the generic approach is really generic, and what it takes to add a new type of plugin. I don't think it'll be *totally* generic; a given plugin type might best have some adjustments to create the PluginInfo. For example, the ".placement-plugin" name should be added to the PluginInfo when the XML element is `<placementPlugin>`. While that could be done in SolrXmlConfig (reading solr.xml), such an idiosyncrasy feels specific to the nature of the cluster edit API/JSON that maybe could be in another spot (unsure). > it seems that there is no validation that a <clusterSingleton/> tag does indeed defines a cluster singleton. I don't recall ever making a mistake of that nature, probably also because the class name is nearly always indicative of the type, so it'd look wrong if it was wrong as well. Validation would be nice but not a requirement. I leave the choice to validate or not up to Paul. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
