epugh commented on code in PR #2232:
URL: https://github.com/apache/solr/pull/2232#discussion_r1620568318
##########
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java:
##########
@@ -329,4 +355,8 @@ private static MetricsConfiguration
loadMetricsConfiguration(String configPath)
throw new RuntimeException(e);
}
}
+
Review Comment:
Somewhere we have code that lets you look up these settings from system
variable or environment variable or solr configuration file.. That may be only
applicable to main Solr code base however...!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
