eivinhb commented on code in PR #2232:
URL: https://github.com/apache/solr/pull/2232#discussion_r1621372850


##########
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java:
##########
@@ -329,4 +355,8 @@ private static MetricsConfiguration 
loadMetricsConfiguration(String configPath)
       throw new RuntimeException(e);
     }
   }
+

Review Comment:
   I have a MacPro M3. nodejs-errorlogs are always a pain imho. 
   
   ```
   2024-05-30T18:47:45.324+0200 [QUIET] [system.out] not ok 3 start solr with 
ssl and auth in 9000ms
   2024-05-30T18:47:45.326+0200 [QUIET] [system.out] # (from function 
`assert_output' in file 
~/solr/.gradle/node/packaging/node_modules/bats-assert/src/assert.bash, line 
247,
   2024-05-30T18:47:45.326+0200 [QUIET] [system.out] #  in test file 
test/test_ssl.bats, line 159)
   2024-05-30T18:47:45.328+0200 [QUIET] [system.out] #   `assert_output 
--partial '"status":0'' failed
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to