eivinhb commented on code in PR #2232:
URL: https://github.com/apache/solr/pull/2232#discussion_r1621089402
##########
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java:
##########
@@ -329,4 +355,8 @@ private static MetricsConfiguration
loadMetricsConfiguration(String configPath)
throw new RuntimeException(e);
}
}
+
Review Comment:
Yeah. The exporter has very little to do with Solr, except being shipped in
the same docker (not slim) image. I can't find any dependency to Solr core.
Thus I belive that this has a completely separate configuration.
That is why I opted to use the same name for environment variables that is
used in Solr to ease the configuration of this in a production environment, eg.
Kubernetes.
When I try and run `./gradlew integrationTests --tests test_ssl.bats` it
fails for me (exit 1), giving a novice like me in Solr development little
confidence to create more tests based on them.
`test_start_solr.bats` works fine though.
I might try and rebase on the latest from main again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
