epugh commented on code in PR #2232:
URL: https://github.com/apache/solr/pull/2232#discussion_r1621236557
##########
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java:
##########
@@ -329,4 +355,8 @@ private static MetricsConfiguration
loadMetricsConfiguration(String configPath)
throw new RuntimeException(e);
}
}
+
Review Comment:
what environment are you in? I suppose a `test_prometheus.bats` without
SSL would be good enough to start with.
I've been mulling over, should the .bats tests be moved from somewhat "unit
style for scripts" type tests to a more heavyweight integration test.. i.e,
fire up a SSL encyrpted Solr with SSL Zookeeper with Basic Auth enabled, and
then test various things like Prometheus exporter ;-).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
