rahulgoswami opened a new pull request, #3347: URL: https://github.com/apache/solr/pull/3347
https://issues.apache.org/jira/browse/SOLR-7962 <!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Solr: * https://issues.apache.org/jira/projects/SOLR For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA. To create a Jira issue, you will need to create an account there first. The title of the PR should reference the Jira issue number in the form: * SOLR-####: <short description of problem or changes> SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description - solr.cmd wasn't passing additional arguments to SolrCLI when running an example (-e option) - Parsing of the prepared command line in RunExampleTool was breaking due to certain characters in the additional args. Eg: -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:18983". commons-cli had to be "signaled" to ask cmd.exe to preserve the quotes while passing to start.cmd - If an additional arg (supplied with "--jvm-opts") starts with "-D", the parsing breaks. # Solution - Pass additional args to SolrCLI when running with -e - Parse the command in RunExampleTool without the additional args to prepare excec.CommandLine and then add the addtional args separately with quotes preserved. - If a system property (-D) is passed as an additional argument with --jvm-opts, pass it along to the RunExampleTool, unlike the other -D arguments. Please provide a short description of the approach taken to implement your solution. # Tests Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem. # Checklist Please review the following and check all that apply: - [ ] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [ ] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
