rahulgoswami commented on PR #3347: URL: https://github.com/apache/solr/pull/3347#issuecomment-2889551976
> The bug is in the test, not the fix, and it is seems to be because of a nuance in the /admin/info/properties that got inadvertently uncovered as part of this testing. I take back the part where I said the issue with tests is because of a nuance in /admin/info/properties. I copy/pasted certain parts of the test from another test in TestSolrCLIRunExample (testExample()), which causes RunExampleTool's startSolr() method to end up calling "solr" script instead of "solr.cmd" (I would expect this to throw an error on Windows, but it doesn't. I am guessing it's got something to do with the custom executor (RunExampleExecutor) that the tests use). Upon further examination seems like the existing testExample() uses a custom RunExampleExecutor to execute the launching process. This launches Solr in embedded mode binding to a pre-declared server Socket. In effect, it seems like a new JVM instance is never launched. Which is why the system property sent with --jvm-opts doesn't reflect. This is not the case when actually running the example from CLI, and hence that works as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
