rahulgoswami commented on PR #3347: URL: https://github.com/apache/solr/pull/3347#issuecomment-2889517954
> Great progress, and this stuff is gnarly to test! (and easy to break, so great to get some tests) Sigh! Cannot get tests for this part to run correctly. At this point I have spent wayyyy more time trying to get the tests to run successfully than I spent fixing the issue. The CLI launches the Java process which launches the CLI which launches the actual Solr process. Easy peasy! ...Not! Not when I have to replicate this in tests. :( [Just to recap, with this fix, launching the example with --jvm-opts via CLI works fine on both Windows and Solr. It's just that it's harder than I thought to replicate this behavior in tests, which is what I am working on.] The other tests for RunExampleTool are launching Solr in embedded mode which won't work for this PR. This is since I need to test for the presence of --jvm-args which needs to be passed at the launch of the Solr instance and cannot be tested "within" an already running JVM of the test suite. Rant over....back to fixing the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
