rahulgoswami commented on code in PR #3347:
URL: https://github.com/apache/solr/pull/3347#discussion_r2087128207
##########
solr/bin/solr.cmd:
##########
@@ -752,7 +752,7 @@ IF NOT "%EXAMPLE%"=="" (
-Dlog4j.configurationFile="file:///%DEFAULT_SERVER_DIR%\resources\log4j2-console.xml"
^
-Dsolr.install.symDir="%SOLR_TIP%" ^
-classpath
"%DEFAULT_SERVER_DIR%\solr-webapp\webapp\WEB-INF\lib\*;%DEFAULT_SERVER_DIR%\lib\ext\*"
^
- org.apache.solr.cli.SolrCLI run_example --script "%SDIR%\solr.cmd" -e
%EXAMPLE% --server-dir "%SOLR_SERVER_DIR%" ^
+ org.apache.solr.cli.SolrCLI run_example --script "%SDIR%\solr.cmd" -e
%EXAMPLE% --server-dir "%SOLR_SERVER_DIR%" --jvm-opts "%SOLR_ADDL_ARGS%" ^
Review Comment:
This was definitely the main reason. However even after passing it, it was
breaking apart in RunExampleTool downstream. Looks like CommandLine.parse() was
not preserving the quotes around the additional arguments causing cmd invoked
by executor.execute() to break up the argument value in unexpected ways. Hence
start.cmd called by RunExampleTool gets broken arguments. Linux shell doesn't
seem to be that finicky and handles this fine. Fixed that for Windows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
