dsmiley commented on code in PR #4048:
URL: https://github.com/apache/solr/pull/4048#discussion_r2691475105
##########
dev-docs/gradle-help/dependencies.txt:
##########
Review Comment:
@risdenk please review this; I'd love to have your input
##########
solr/modules/extraction/build.gradle:
##########
@@ -38,9 +38,9 @@ dependencies {
// For 'tikaserver' backend
implementation libs.eclipse.jetty.client
- permitUsedUndeclared libs.eclipse.jetty.http
- permitUsedUndeclared libs.eclipse.jetty.util
- permitUsedUndeclared libs.eclipse.jetty.io
+ implementation libs.eclipse.jetty.http
+ implementation libs.eclipse.jetty.util
+ implementation libs.eclipse.jetty.io
Review Comment:
@janhoy were you trying to avoid simply using `implementation` for some
reason?
##########
solr/core/build.gradle:
##########
@@ -79,8 +74,6 @@ dependencies {
runtimeOnly libs.apache.lucene.analysis.phonetic
runtimeOnly libs.apache.lucene.backward.codecs
implementation libs.apache.lucene.codecs
- implementation libs.apache.lucene.backward.codecs
- permitUnusedDeclared libs.apache.lucene.backward.codecs
Review Comment:
nonetheless, it's still on the runtime classpath (lockfile is truth on such
matters).
##########
solr/solrj-streaming/gradle.lockfile:
##########
@@ -128,9 +118,8 @@
org.apache.lucene:lucene-spatial-extras:10.3.2=jarValidation,testRuntimeClasspat
org.apache.lucene:lucene-spatial3d:10.3.2=jarValidation,testRuntimeClasspath
org.apache.lucene:lucene-suggest:10.3.2=jarValidation,testRuntimeClasspath
org.apache.lucene:lucene-test-framework:10.3.2=jarValidation,testCompileClasspath,testRuntimeClasspath
-org.apache.yetus:audience-annotations:0.12.0=permitTestUnusedDeclared
-org.apache.zookeeper:zookeeper-jute:3.9.4=jarValidation,permitTestUnusedDeclared,testCompileClasspath,testRuntimeClasspath
-org.apache.zookeeper:zookeeper:3.9.4=jarValidation,permitTestUnusedDeclared,testCompileClasspath,testRuntimeClasspath
+org.apache.zookeeper:zookeeper-jute:3.9.4=jarValidation,testCompileClasspath,testRuntimeClasspath
Review Comment:
see; it's still on the test runtime classpath, so may be consulted in tests
at runtime
##########
solr/core/build.gradle:
##########
@@ -21,13 +21,11 @@ description = 'Apache Solr Core'
dependencies {
api platform(project(":platform"))
- permitUnusedDeclared platform(project(":platform"))
// Spotbugs Annotations are only needed for old findbugs
// annotation usage like in Zookeeper during compilation time.
// It is not included in the release so exclude from checks.
compileOnly libs.spotbugs.annotations
testCompileOnly libs.spotbugs.annotations
- permitUnusedDeclared libs.spotbugs.annotations
Review Comment:
because recent plugin update considers compileOnly as such (i.e.
automatically)
##########
solr/core/build.gradle:
##########
@@ -21,13 +21,11 @@ description = 'Apache Solr Core'
dependencies {
api platform(project(":platform"))
- permitUnusedDeclared platform(project(":platform"))
Review Comment:
this was a bizarre one since it's a "platform"
##########
solr/modules/cuvs/build.gradle:
##########
@@ -28,15 +28,11 @@ dependencies {
implementation project(':solr:core')
implementation project(':solr:solrj')
implementation libs.apache.lucene.core
- implementation libs.apache.lucene.backward.codecs
implementation libs.slf4j.api
testImplementation project(':solr:test-framework')
testImplementation libs.apache.lucene.testframework
testImplementation libs.junit.junit
testImplementation libs.commonsio.commonsio
-
- // lucene-backward-codecs is a transitive dependency from cuvs-lucene but
required in lockfile
Review Comment:
This explanation doesn't make sense IMO; instead it tells me that the author
of the comment doesn't know to write locks first. Maybe our build is
complicated for many folks :-(
##########
solr/solrj-streaming/build.gradle:
##########
@@ -39,10 +39,5 @@ dependencies {
testImplementation libs.junit.junit
testImplementation libs.hamcrest.hamcrest
- testImplementation(libs.apache.zookeeper.zookeeper, {
- exclude group: "org.apache.yetus", module: "audience-annotations"
- })
- permitTestUnusedDeclared libs.apache.zookeeper.zookeeper
-
permitTestUsedUndeclared project(':solr:solrj-streaming') // duh!
Review Comment:
so weird...
##########
solr/modules/sql/build.gradle:
##########
@@ -21,7 +21,6 @@ description = 'SQL Module'
dependencies {
implementation platform(project(':platform'))
- permitUnusedDeclared platform(project(":platform"))
Review Comment:
Very weird -- using permitBlahBlah on a *platform*. A platform based
declaration isn't really a dependency, it just imports _constraints_ on
dependencies (not actually depending on those things).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
