janhoy commented on code in PR #4048:
URL: https://github.com/apache/solr/pull/4048#discussion_r2692460845
##########
solr/modules/extraction/build.gradle:
##########
@@ -38,9 +38,9 @@ dependencies {
// For 'tikaserver' backend
implementation libs.eclipse.jetty.client
- permitUsedUndeclared libs.eclipse.jetty.http
- permitUsedUndeclared libs.eclipse.jetty.util
- permitUsedUndeclared libs.eclipse.jetty.io
+ implementation libs.eclipse.jetty.http
+ implementation libs.eclipse.jetty.util
+ implementation libs.eclipse.jetty.io
Review Comment:
Strange. I must have added `libs.eclipse.jetty.client` first (which brings
in the other three transitively), and then reacted to the error message by
permitting them instead of adding explicit. I don't recall exactly what
happened in october, but I may have misinterpreted the error message from the
plugin during implementation, and then it was never revisited before merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
