dsmiley commented on code in PR #4048:
URL: https://github.com/apache/solr/pull/4048#discussion_r2692574060
##########
solr/solrj-streaming/build.gradle:
##########
@@ -39,10 +39,5 @@ dependencies {
testImplementation libs.junit.junit
testImplementation libs.hamcrest.hamcrest
- testImplementation(libs.apache.zookeeper.zookeeper, {
- exclude group: "org.apache.yetus", module: "audience-annotations"
- })
- permitTestUnusedDeclared libs.apache.zookeeper.zookeeper
-
permitTestUsedUndeclared project(':solr:solrj-streaming') // duh!
Review Comment:
I see that other modules (e.g. SolrJ) have testImplementation with an
explicit dependency on the module itself, which you had added back when you
added the cutterslade plugin. So we have cutterslade to thank for this
verbosity. **Yes of course a module's tests depend on the module!** This is
how Gradle or any build system would be expected to work. This is a bad side
of the plugin -- a flaw; requiring needless verbosity to state the obvious.
I'll switch it to for consistency with our other files (thanks to
cutterslade), and to remove a sad "permit", and report the bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
