risdenk commented on code in PR #4048:
URL: https://github.com/apache/solr/pull/4048#discussion_r2691640595
##########
solr/solrj-streaming/build.gradle:
##########
@@ -39,10 +39,5 @@ dependencies {
testImplementation libs.junit.junit
testImplementation libs.hamcrest.hamcrest
- testImplementation(libs.apache.zookeeper.zookeeper, {
- exclude group: "org.apache.yetus", module: "audience-annotations"
- })
- permitTestUnusedDeclared libs.apache.zookeeper.zookeeper
-
permitTestUsedUndeclared project(':solr:solrj-streaming') // duh!
Review Comment:
There is no flaw here. For the tests, the tests require classes from
`solr:solrj-streaming` to compile. You could conceivably write tests without
requiring the classes from `solr:solrj-streaming`.
If you put testImplementation as intended in Gradle, it would show that this
module for the tests requires `solr:solrj-streaming` classes to compile. Thats
not the plugin being wrong.
The wrong thing is that we don't have a `testImplementation` line that
references `solr:solrj-streaming`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
