HoustonPutman commented on code in PR #4046:
URL: https://github.com/apache/solr/pull/4046#discussion_r2699661865
##########
solr/core/src/test/org/apache/solr/handler/admin/api/CreateAliasAPITest.java:
##########
@@ -325,7 +358,7 @@ public void
testConvertsV1ParamsForMultiDimensionalAliasToV2RequestBody() {
v1Params.add("name", "someAliasName");
v1Params.add("router.name", "Dimensional[time,category]");
v1Params.add("router.0.field", "someField");
- v1Params.add("router.0.start", "NOW");
+ v1Params.add("router.0.start", "NOW/HOUR");
Review Comment:
So some of these had to change because the `createRemoteMessage()` don't do
any validations, but the actual API methods do. So `NOW` is not a supported
value for `router.0.start`, but that wasn't checked by `createRemoteMessage`,
so it didn't matter before. Now that we use the actual API it matters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
