HoustonPutman commented on code in PR #4046:
URL: https://github.com/apache/solr/pull/4046#discussion_r2699670851
##########
solr/core/src/test/org/apache/solr/handler/admin/api/BalanceShardUniqueAPITest.java:
##########
@@ -68,32 +74,35 @@ public void testReportsErrorIfPropertyToBalanceIsMissing() {
final var requestBody = new BalanceShardUniqueRequestBody();
final SolrException thrown =
expectThrows(
- SolrException.class,
- () -> {
- final var api = new BalanceShardUnique(null, null, null);
- api.balanceShardUnique("someCollName", requestBody);
- });
+ SolrException.class, () -> api.balanceShardUnique("someCollName",
requestBody));
assertEquals(400, thrown.code());
assertEquals("Missing required parameter: property", thrown.getMessage());
}
@Test
- public void testCreateRemoteMessageAllProperties() {
+ public void testCreateRemoteMessageAllProperties() throws Exception {
Review Comment:
I mean we are still just ultimately testing that the remote message being
created is correct, so I think it's safe to keep the same name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
