HoustonPutman commented on code in PR #4046:
URL: https://github.com/apache/solr/pull/4046#discussion_r2699793184
##########
solr/core/src/java/org/apache/solr/cloud/api/collections/MigrateCmd.java:
##########
@@ -312,17 +309,26 @@ private void migrateKey(
configName,
CollectionHandlingUtils.CREATE_NODE_SET,
sourceLeader.getNodeName());
- if (asyncId != null) {
- String internalAsyncId = asyncId + Math.abs(System.nanoTime());
- props.put(ASYNC, internalAsyncId);
+ String internalAsyncId = null;
+ if (adminCmdContext.getAsyncId() != null) {
Review Comment:
So since this is mainly handled by the `ShardRequestTracker`, and very few
Cmds actually create their own internal or sub request AsyncId directly, I
don't think we really need a utility. Honestly I'm not sure these commands
actually need to do it themselves at all. But not really in scope for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
