HoustonPutman commented on code in PR #4046:
URL: https://github.com/apache/solr/pull/4046#discussion_r2699850085
##########
solr/core/src/java/org/apache/solr/handler/admin/api/AliasProperty.java:
##########
@@ -128,63 +124,60 @@ public SolrJerseyResponse createOrUpdateAliasProperty(
recordCollectionForLogAndTracing(null, solrQueryRequest);
- SolrJerseyResponse response =
instantiateJerseyResponse(SolrJerseyResponse.class);
- modifyAliasProperty(aliasName, propName, requestBody.value);
+ var response =
instantiateJerseyResponse(SubResponseAccumulatingJerseyResponse.class);
+ modifyAliasProperty(response, aliasName, propName, requestBody.value);
return response;
}
@Override
@PermissionName(COLL_EDIT_PERM)
- public SolrJerseyResponse deleteAliasProperty(String aliasName, String
propName)
- throws Exception {
+ public SubResponseAccumulatingJerseyResponse deleteAliasProperty(
Review Comment:
So weirdly only `updateAliasProperties` supports async currently, not even
`createOrUpdateAliasProperty`. So for now only `updateAliasProperties` will use
the `AsyncJerseyResponse`. The other two will use `SolrJerseyResponse`.
I will go through the other files and make sure I'm not changing any of
these when I shouldn't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
