dsmiley commented on code in PR #4119:
URL: https://github.com/apache/solr/pull/4119#discussion_r2966051754


##########
solr/core/src/java/org/apache/solr/servlet/SolrServlet.java:
##########
@@ -177,22 +140,23 @@ protected HttpSolrCall getHttpSolrCall(
     } catch (UnavailableException e) {
       throw new SolrException(ErrorCode.SERVER_ERROR, "Core Container 
Unavailable");
     }
-    return solrCallFactory.createInstance(this, path, cores, request, 
response, retry);
+    return solrCallFactory.createInstance(path, cores, request, response, 
retry);
   }
 
-  /** internal API */
+  /**
+   * @lucene.internal
+   */
   public interface HttpSolrCallFactory {

Review Comment:
   I toyed with moving this to HttpSolrCall.  Shrug... it wasn't _obviously_ 
better so I am leaving it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to