KhushJain opened a new pull request, #4394: URL: https://github.com/apache/solr/pull/4394
https://issues.apache.org/jira/browse/SOLR-XXXXX <!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Solr: * https://issues.apache.org/jira/projects/SOLR For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA. To create a Jira issue, you will need to create an account there first. The title of the PR should reference the Jira issue number in the form: * SOLR-####: <short description of problem or changes> SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description `Rollup` function to support `countDist` (count distinct) statistics in `/stream` handler. # Solution Implement the existing `CountDistinctMetric` stub in the streaming expressions framework: **`CountDistinctMetric.java`**: 1. Was a no-op stub. `update()` did nothing and `getValue()` returned null. Now uses `HashSet<Object>` to track distinct non-null values per group. 2. Fixed `toExpression()` which emitted a spurious `outputLong` parameter producing malformed expressions like `countDist(a_i,true)` 3. Added parameter count validation in the`StreamExpression` constructor. # Tests Updated existing tests in `StreamDecoratorTest.java` and `StreamingTest.java`: - **`StreamDecoratorTest.testRollupStream`**: Added `countDist(a_i)` and `countDist(a_s)` to the expression and asserted. - **`StreamDecoratorTest.testHashRollupStream`**: Same additions for hash-based rollup. - **`StreamingTest.testRollupStream`**: Added `CountDistinctMetric("a_i")` and `CountDistinctMetric("a_s")` to the metrics array and asserted, including the null grouping field test. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [x] I have added tests for my changes. - [x] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) - [x] I have added a [changelog entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
