KhushJain commented on PR #4394: URL: https://github.com/apache/solr/pull/4394#issuecomment-4371920187
> So was this a partly started feature that was never finished?? The class existed and worked for facets and stats where it was just used as an identifier that gets push down to json facet api to do the actual computation. So update()/getValue() was never called in that workflow. For rollup, it needs implementations for these methods to work. Currently countDist was just returning null. So even though the method is registered, it would have just returned null when invoked. This PR fills in that implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
