KhushJain commented on code in PR #4394:
URL: https://github.com/apache/solr/pull/4394#discussion_r3182399772
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/metrics/CountDistinctMetric.java:
##########
@@ -81,14 +90,11 @@ public String[] getColumns() {
@Override
public Number getValue() {
- // No op for now
- return null;
+ return distinctValues.size();
}
@Override
public StreamExpressionParameter toExpression(StreamFactory factory) throws
IOException {
- return new StreamExpression(getFunctionName())
- .withParameter(columnName)
- .withParameter(Boolean.toString(outputLong));
+ return new StreamExpression(getFunctionName()).withParameter(columnName);
Review Comment:
This is the SQL module's map-reduce path, not the streaming expression path.
This PR targets countDist in streaming expression rollup()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
