KhushJain commented on code in PR #4394:
URL: https://github.com/apache/solr/pull/4394#discussion_r3182320671
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/metrics/CountDistinctMetric.java:
##########
@@ -66,7 +72,10 @@ private void init(String functionName, String columnName) {
@Override
public void update(Tuple tuple) {
- // Nop for now
+ Object value = tuple.get(columnName);
+ if (value != null) {
+ distinctValues.add(value);
+ }
Review Comment:
`APPROX_COUNT_DISTINCT / hll` constant existed but the code was a complete
no-op. I'd argue that's a separate feature and needs its own function
registered like `hll()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
