epugh commented on code in PR #4477:
URL: https://github.com/apache/solr/pull/4477#discussion_r3328757915
##########
solr/core/src/java/org/apache/solr/security/Sha256AuthenticationProvider.java:
##########
@@ -165,6 +166,10 @@ public Map<String, Object> edit(Map<String, Object>
latestConf, List<CommandOper
cmd.addError("name and password must be non-null");
return null;
}
+ if (e.getKey().equals(String.valueOf(e.getValue()))) {
Review Comment:
now we have security rules being enforced in multiple places... maybe have
one place to enforce them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
