Copilot commented on code in PR #4477:
URL: https://github.com/apache/solr/pull/4477#discussion_r3329333705
##########
solr/core/src/java/org/apache/solr/cli/AuthTool.java:
##########
@@ -286,6 +293,14 @@ private void handleBasicAuth(CommandLine cli) throws
Exception {
String.format(
Locale.ROOT, "Successfully enabled basic auth with username
[%s].", username);
echo(successMessage);
+ CLIO.out(
+ "\nIMPORTANT: The following template users have been created
with NO password set"
+ + " and cannot log in until passwords are assigned:");
+ CLIO.out(" - admin (roles: admin, index, search)");
+ CLIO.out(" - index (roles: index, search)");
+ CLIO.out(" - search (roles: search)");
+ CLIO.out(
+ "Set their passwords using the Admin UI Security page or the
authentication API.");
Review Comment:
The template-user notice is printed even when `--update-include-file-only`
is used. In that mode the tool explicitly skips updating `security.json`, so
the template users are not actually created; this message is misleading.
##########
solr/solr-ref-guide/modules/deployment-guide/pages/solr-control-script-reference.adoc:
##########
@@ -893,7 +893,7 @@ For more information on Basic Authentication support
specifically, see the secti
The `bin/solr auth enable` command makes several changes to enable Basic
Authentication:
-* Take the base
https://github.com/apache/solr/blob/main/solr/core/resources/security.json[security.json]
file, evolves it using `auth` command parameters, and uploads the new file to
ZooKeeper.
+* Take the base
https://github.com/apache/solr/blob/main/solr/core/src/resources/security.json[security.json]
file, evolves it using `auth` command parameters, and uploads the new file to
ZooKeeper.
Review Comment:
This bullet has a grammatical issue ("Take ... evolves"). Consider
rephrasing for clarity since this line was already touched for the link update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
