janhoy commented on code in PR #4477:
URL: https://github.com/apache/solr/pull/4477#discussion_r3329175466


##########
solr/core/src/java/org/apache/solr/security/Sha256AuthenticationProvider.java:
##########
@@ -93,6 +93,7 @@ public void init(Map<String, Object> pluginConfig) {
 
   @Override
   public boolean authenticate(String username, String password) {
+    if (username.equals(password)) return false;

Review Comment:
   The reasoning for this is written in the PR description:
   
   > As a side effect, any existing installation retaining the well-known 
template credentials will have those accounts silently disabled until the 
passwords are changed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to