janhoy commented on code in PR #4477:
URL: https://github.com/apache/solr/pull/4477#discussion_r3329196204
##########
solr/webapp/web/js/angular/controllers/security.js:
##########
@@ -412,6 +412,12 @@ solrAdminApp.controller('SecurityController', function
($scope, $timeout, $cooki
return false;
}
+ var username = $scope.upsertUser.username ?
$scope.upsertUser.username.trim() : "";
+ if (password === username) {
Review Comment:
Yea, this is in frontend, so hard to enforce with same DRY class. But peraps
once the new Kotlin UI has taken over it can use the same password-policy class
to check/enforce?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
