serhiy-bzhezytskyy commented on code in PR #4612:
URL: https://github.com/apache/solr/pull/4612#discussion_r3552837011
##########
solr/modules/sql/build.gradle:
##########
@@ -22,9 +22,6 @@ description = 'SQL Module'
dependencies {
implementation platform(project(':platform'))
implementation project(':solr:core')
- implementation project(':solr:solrj')
- implementation project(':solr:solrj-streaming')
Review Comment:
These classes (CatStream, ClassifyStream, AnalyzeEvaluator) are registered
as streaming expression functions — SolrDefaultStreamFactory wires them:
`withFunctionName("cat", CatStream.class)`, etc. They exist specifically to
plug into the streaming framework. They must extend TupleStream/Expressible —
that's the whole point of them.
I just tried it — if core has solrj-streaming as implementation instead of
api, it builds fine as long as sql/benchmark declare it themselves (sql tests
pass). But DAGP immediately says it should be api again.
So it is part of core's public API now and I don't see simple way to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
