serhiy-bzhezytskyy commented on PR #4612: URL: https://github.com/apache/solr/pull/4612#issuecomment-4927081321
Double-checked before leaving it — ran buildHealth again on the cleaned-up build to see what DAGP flags now. Two things, and both are wrong for us: it calls `opentelemetry-sdk-metrics` unused (it's not — JettySolrRunner uses it at runtime, the compile-blindness thing again), and it wants test-framework to re-declare the `api project(:api/:solrj)` we just removed as redundant. So right now it's mostly arguing against the decisions we made here. The cleanup value it did give is already in this PR either way. So I'll stand by "opt-in, not a gate" — but no strong case that it earns ongoing keep. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
