serhiy-bzhezytskyy commented on PR #4612: URL: https://github.com/apache/solr/pull/4612#issuecomment-4933919767
Pushed the `getDefaultHttpSolrClient()` → `HttpSolrClient` change here to keep it in context. It works out how you expected — modules don't care about the subtype: cross-dc was the only module calling it, uses base methods only, so **cross-dc drops solrj-jetty** now. Inside core, 4 callers widened cleanly; 5 keep a cast where they actually use Jetty-only API (`Builder.withHttpClient` sharing transport internals, `getHttpClient()` for raw proxying, the async `requestWithBaseUrl(baseUrl, fn)` overload). Pure compile-time change, runtime unchanged. Full core + cross-dc tests pass. This PR has grown a lot though — DAGP reporting, the redundant-declaration cleanup, and now this return-type change are really three separate things. How do you want to handle it? Options I see: - split into separate PRs (DAGP / redundancy cleanup / getDefaultHttpSolrClient) so each can be judged on its own, - or keep as-is if you'd rather review together. Let me know what action I should take with this PR and the topics touched here. Hope I'm contributing value, not noise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
