dsmiley commented on code in PR #4612:
URL: https://github.com/apache/solr/pull/4612#discussion_r3553965963
##########
solr/modules/sql/build.gradle:
##########
@@ -22,9 +22,6 @@ description = 'SQL Module'
dependencies {
implementation platform(project(':platform'))
implementation project(':solr:core')
- implementation project(':solr:solrj')
- implementation project(':solr:solrj-streaming')
Review Comment:
The "sql" module is definitely the unusual exception with regards to it's
dependency on solrj-streaming from within Solr. I think that should be
explicit -- not "api".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
