serhiy-bzhezytskyy commented on code in PR #4632:
URL: https://github.com/apache/solr/pull/4632#discussion_r3564683749
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateBaseSolrClient.java:
##########
@@ -158,6 +176,7 @@ protected ConcurrentUpdateBaseSolrClient(Builder builder) {
this.basePath = builder.baseSolrUrl;
this.defaultCollection = builder.defaultCollection;
this.pollQueueTimeMillis = builder.pollQueueTimeMillis;
+ this.errorHandler = builder.errorHandler;
Review Comment:
Confirmed there's no solrj-side deprecation helper — solrj only has
@Deprecated + ad-hoc log.warn, and DeprecationLog is core-only as noted. The
one thing DeprecationLog adds over a bare log.warn is log-once dedup + the
org.apache.solr.DEPRECATED.* logger prefix. To avoid warning on every client
construction I'd add a small log-once guard here in the client. If the project
later wants solrj to share core's deprecation convention, a tiny solrj-side
helper would be a clean follow-up — but I'd keep this PR scoped to the guard.
Sound good?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
