epugh commented on code in PR #4474:
URL: https://github.com/apache/solr/pull/4474#discussion_r3595384399
##########
solr/core/src/java/org/apache/solr/security/CertAuthPlugin.java:
##########
@@ -102,7 +104,10 @@ public boolean doAuthenticate(
HttpServletRequest request, HttpServletResponse response, FilterChain
filterChain)
throws Exception {
X509Certificate[] certs =
- (X509Certificate[])
request.getAttribute("javax.servlet.request.X509Certificate");
+ (X509Certificate[])
request.getAttribute(CURRENT_REQUEST_ATTRIBUTE_NAME);
+ if (certs == null || certs.length == 0) {
+ certs=(X509Certificate[])
request.getAttribute(OLD_REQUEST_ATTRIBUTE_NAME);
Review Comment:
@heitzjm these days, Solr only runs in Jetty, and we've been getting more
specific to just that. Notice we no longer produce a .war file. I think the
only place where you might have solr run in another container is via the
EmbeddedSolr approach.. Having said that, I don't think we have made a "This
is how it is" explicit decision, and I'm fine with the backcompat for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
